Skip to content

fix(form-core): respect dontValidate option in formApi array modifiers #1775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(form-core): respect dontValidate option in formApi array modifiers #1775

wants to merge 3 commits into from
+46 −21

Conversation

PejmanNik
Copy link

fix #1764

🎯 Changes

check the dontValidate option in array modifiers before applying validation

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

fix(form-core): respect dontValidate option in formApi array modifiers
fc269f5 
check the `dontValidate` option in array modifiers before applying validation

fix TanStack#1764
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: be6add4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@tanstack/form-core Patch
@tanstack/angular-form Patch
@tanstack/form-devtools Patch
@tanstack/lit-form Patch
@tanstack/react-form Patch
@tanstack/solid-form Patch
@tanstack/svelte-form Patch
@tanstack/vue-form Patch
@tanstack/react-form-devtools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@PejmanNik
Copy link
Author

I couldn't find a single test that checks the dontValidate , should I create a parameterized test for it? What is your plan?

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Sep 28, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit be6add4

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 13s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-28 13:06:57 UTC

LeCarbonator
LeCarbonator approved these changes Sep 28, 2025
View reviewed changes
Copy link
Contributor

@LeCarbonator LeCarbonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Not sure why codecov is not tracking this, but either way, unit tests for meta options would be great!

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 28, 2025 •
edited
Loading

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1775

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1775

@tanstack/form-devtools

npm i https://pkg.pr.new/@tanstack/form-devtools@1775

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1775

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1775

@tanstack/react-form-devtools

npm i https://pkg.pr.new/@tanstack/react-form-devtools@1775

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1775

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@1775

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1775

commit: be6add4

@codecov Codecov
Copy link

codecov bot commented Sep 28, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.53%. Comparing base (6892ed0) to head (be6add4).
⚠️ Report is 20 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1775      +/-   ##
==========================================
+ Coverage   90.35%   90.53%   +0.18%     
==========================================
  Files          38       38              
  Lines        1752     1797      +45     
  Branches      444      464      +20     
==========================================
+ Hits         1583     1627      +44     
- Misses        149      150       +1     
  Partials       20       20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@PejmanNik
Copy link
Author

Thank you, I'll try to create a separate PR for adding tests

@LeCarbonator
Copy link
Contributor

I'll merge later today. Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeCarbonator LeCarbonator LeCarbonator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

moveFieldValues doesn’t respect UpdateMetaOptions
2 participants
@PejmanNik @LeCarbonator